Working with delivery remainders: a word of caution

 


While updating the delivery remainder through code, you must be aware of the following code, which is widely available in the Google market:


 SalesUpdateRemain::construct().updateDeliverRemainder(salesLine2update,

                                                                                        qty2Delv,

                                                                                        qty2Delv);

However, this won't help you, if you are working for a Call-center based client/retail clients/royalty clients . Retail clients have a facility known as: 'Complete' sales orders, which processes any payments or refunds, if you are making, from F&O.  

Suppose I have ordered initially 5 qtys and want to receive only 3 out of them, scrapping the rest 2, I need to consequently update the same using delivery reminders. However, if you want to automate the same (some integration staging table from where a batch reads and updates the deliver reminder), then the above code won't work, while 'Completing' the record, runtime.

This is because, if you see the standard code, the standard calls for adjusting the MCRCustPayment posting, which the above code is not doing. Hence, you have to call the below method, along with the above:

this.callMCRPaymentCancellation(salesLine2Updatel);

The above method looks like this:

void callMCRPaymentCancellation(SalesLine _callerSalesLine)

    {

        MCRSalesOrderCancellation mcrSalesOrderCancellation;


        if (isConfigurationkeyEnabled(configurationKeyNum(MCRCallCenter)))

        {

            mcrSalesOrderCancellation = new MCRSalesOrderCancellation();

            mcrSalesOrderCancellation.preCancel(SalesTable::find(_callerSalesLine.SalesId));

        }


        if (isConfigurationkeyEnabled(configurationKeyNum(MCRCallCenter)))

        {

            SalesTable salesTable = SalesTable::find(_callerSalesLine.SalesId, true);

                    

            if (_callerSalesLine.SalesStatus == SalesStatus::Canceled)

            {

                SalesLine salesLineLocal = SalesLine::findRecId(_callerSalesLine.RecId);

                mcrSalesOrderCancellation.postCancelLine(salesLineLocal);

                

                if (salesTable.SalesStatus == SalesStatus::Canceled)

                {

                    mcrSalesOrderCancellation.postCancelOrder(salesTable);

                }

            }


            

            // If sales order is paid by loyalty create the refund loyalty lines and post them as part of this process

            if (salesTable.SalesStatus != SalesStatus::Canceled)

            {

                mcrSalesOrderCancellation.RefundLoyaltyPointsForSalesLine(salesTable, _callerSalesLine);

            }

            mcrSalesOrderCancellation.postCancelAdjPayment(salesTable);

        }

    }


}


Yes, this is already present in the Form: SalesUpdateRemain\\Methods\\closeOk method. Unfortunately, the standard has all defined it locally in this form, hence in this case, you have to reinvent the wheel.

That's it guys!

It will create necessary refund/payment lines and you can call methods for Completing the sales order, seamlessly. 


Comments

Post a Comment

Popular posts from this blog

X++ : mistakes which developers commit the most

Image
   The most important thing is to remember where and when to write the code. a. Developers have an inherent habit of writing erratic select statements: select * from custTable where custTable.AccountNum == <SomeValue> Where in essence we need to make use of optimized choice of fields in the select statement. b. Making use of 'continue' keywords: While select custTrans where <someConditions> { if (cusTTrans.CustGroup != mappingTable.CustGroup) { continue; } } 'Continue' statements are precisely a very unhygienic way of designing your code. The above statement could have been easily ornamented by using exists/not exists joins. Using Continue statements would eventually result in a high performance impact. Also select statements should be made punctuated with a 'firstonly' clause -- just not from best practise standpoint, but also from performance considerations. c. Writing nested loops: This is a common mistake that perha
Read more

Make your menu items visible on main menu, conditionally,, using this cool feature of D365FO

Image
  Wassup guys? I am sure you must have encountered this situation where you needed to display your menuItems, on main menu, based on some condition, haven't you? This was only possible by using config keys and flights. Things get a bit tricky,  when suppose you have a requirement like this: you need to make it dynamic, by introducing a toggle switch on a field on a paremeter form.  Suppose on Accounts Receivables Parameters >> You have a field called ' Show US customer '. You have a requirement that says when you turn on this toggle, then only the menuItem ' Input SSN details ', under AR module. This is now highly acheivable by leveraging subscription to 'SysMenuNavigationObjectFactory' class, simply by saying a. Create a new class USMenuItemsVisibilityManager b. Copy the following method, with proper documentation (don't change signature/anything else) [SubscribesTo(classstr(SysMenuNavigationObjectFactory), staticdelegatestr(SysMenuNavigationObjec
Read more

Speed up your execution performance by using SysGlobalCaches

Image
  Ever come across a situation where you needed to  a. Using a multi-threaded batch to import a journal header and lines, from a staging table. The table already contains the Journal Ids which you need to assign to the header and allocate the lines under that header. b. You need to continuously check after each line being imported, if the journal with the Id has been created. If not, it will create the header and create the lines under it;  If yes, it will directly create the lines for the header (Find or create). c. As you could rightly guess, this architecture has an inherent sluggishness associated with it -- each time you keep on checking if the header has been created or not, it does mean a lot of performance effects, as a consequence. Also as you can understand it's a multithreaded code, which means each thread has no direct relation with the other -- which does mean there is no way I can talk between the threads/pass on any information. SysGlobalCaches to the rescue: I perso
Read more